Skip to content

Conversation

@bohutang
Copy link
Member

@bohutang bohutang commented Dec 22, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Refactor system.build_options to be more readable and useful for release artifacts:

  • Change schema to key-value: category, name, value.
  • Expose build-time metadata used in release CI: query crate Cargo features, target features, Cargo build profile, and opt-level.

For example:
img_v3_02t7_d7924e8f-ce74-47e4-a615-ce363f64c5dg

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - User requested skipping tests for this PR update

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 22, 2025
@bohutang bohutang marked this pull request as draft December 22, 2025 09:10
@bohutang bohutang added the ci-cloud Build docker image for cloud test label Dec 22, 2025
@github-actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-19137-3527b80-1766404459

note: this image tag is only available for internal use.

@bohutang bohutang marked this pull request as ready for review December 22, 2025 12:02
@bohutang bohutang merged commit b855648 into databendlabs:main Dec 22, 2025
181 of 183 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +31 to +35
let mut features = env::vars()
.filter_map(|(k, v)| {
if !k.starts_with("CARGO_FEATURE_") {
return None;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Wire build.rs into Cargo manifest

The new build script collects query crate features and emits DATABEND_QUERY_CARGO_FEATURES, but src/query/service/Cargo.toml still has no build = "build.rs" entry, so Cargo never executes this script. As a result the environment variable stays unset and system.build_options will always show the cargo features row as not available, defeating the intent of this change in every build profile.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cloud Build docker image for cloud test pr-refactor this PR changes the code base without new features or bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant