Skip to content

chore(query): allow_anonymous when key token is empty #19143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bohutang merged 12 commits into from
Dec 23, 2025
Merged

chore(query): allow_anonymous when key token is empty #19143

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
cae995e
chore(query): allow_anonymous when key token is empty
sundy-li Dec 23, 2025
8795a81
test(sqllogictest): add public S3 stage list regression
bohutang Dec 23, 2025
9377b5c
chore(storage): gate anonymous S3 by credential loader
bohutang Dec 23, 2025
7aa7e48
Merge branch 'main' into allow_anonymous
bohutang Dec 23, 2025
df00536
chore(storage): clarify anonymous S3 comment
bohutang Dec 23, 2025
56c6ad2
fix(storage): enable anonymous S3 access when no explicit credentials…
bohutang Dec 23, 2025
6c3f1da
fix(storage): restore unconditional allow_anonymous and handle Permis…
bohutang Dec 23, 2025
2040996
Revert to df005368: conditional allow_anonymous with disable_credenti…
bohutang Dec 23, 2025
2cf6623
Merge branch 'main' into allow_anonymous
bohutang Dec 23, 2025
3f6b6d7
ci(sqllogic): run public S3 stage test with insecure off
bohutang Dec 23, 2025
683303d
fix(stage): avoid loading creds for external S3 stage
bohutang Dec 23, 2025
83a662e
fix(stage): normalize external S3 stage creds
bohutang Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/storage/src/operator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,14 @@ fn init_s3_operator(cfg: &StorageS3Config) -> Result<impl Builder> {
// Root.
.root(&cfg.root);

if cfg.access_key_id.is_empty()
&& cfg.secret_access_key.is_empty()
&& cfg.security_token.is_empty()
&& cfg.role_arn.is_empty()
{
builder = builder.allow_anonymous();
}

if cfg.storage_class != S3StorageClass::Standard {
// Apply S3 storage class to the operator.
// Note: Some S3-compatible storage systems (e.g., MinIO) may not support
Expand Down
Loading