refactor(meta): upgrade openraft to v0.10.0-alpha.13 #19193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5954c64f79
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
drmingdrmer
force-pushed
the
338-xx
branch
3 times, most recently
from
3372b48 to
086bd0d
Compare
xp-trumpet
reviewed
Jan 5, 2026
xp-trumpet
left a comment
xp-trumpet
left a comment
There was a problem hiding this comment.
@xp-trumpet reviewed 18 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @drmingdrmer).
drmingdrmer
commented
Jan 5, 2026
Member
Author
drmingdrmer
left a comment
drmingdrmer
left a comment
There was a problem hiding this comment.
@drmingdrmer resolved 1 discussion.
Reviewable status: 6 of 18 files reviewed, all discussions resolved (waiting on @xp-trumpet).
drmingdrmer
force-pushed
the
338-xx
branch
2 times, most recently
from
76e12cc to
5ec5af0
Compare
…ized payloads Upgrade openraft dependency and adapt to API changes in the new version. The main changes include a new streaming apply API, updated watch receiver trait methods, and automatic payload size management for AppendEntries. In openraft 0.10.0, `PayloadTooLarge` error was removed. This change implements automatic payload size management in `append_entries()` by reducing entry count and retrying when payloads exceed gRPC limits. Changes: - Upgrade openraft from `v0.10.0-alpha.11` to `v0.10.0-alpha.13` - Update `TypeConfig` to use new `Responder<T>` and `ErrorSource` types - Add type aliases: `WatchReceiver<T>`, `Unreachable`, `EntryResponder` - Change `SMV003::apply_entries()` to accept stream instead of iterator - Replace `.borrow()` with `.borrow_watched()` for watch receivers - Add `From<SnapshotStoreError> for io::Error` implementation - Update tests to use stream-based apply API - Add retry loop in `append_entries()` to handle oversized payloads - Add `build_partial_append_request()` helper for creating partial requests - Check payload size before sending against `advisory_encoding_size()` - Handle `tonic::Code::ResourceExhausted` by reducing entries and retrying - Return `Unreachable` error when single entry exceeds size limit - Remove obsolete `new_append_entries_raft_req()` function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor(meta): upgrade openraft to v0.10.0-alpha.13
Upgrade openraft dependency and adapt to API changes in the new version.
The main changes include a new streaming apply API and updated watch
receiver trait methods.
Changes:
v0.10.0-alpha.11tov0.10.0-alpha.13TypeConfigto use newResponder<T>andErrorSourcetypesWatchReceiver<T>,Unreachable,EntryResponderSMV003::apply_entries()to accept stream instead of iterator.borrow()with.borrow_watched()for watch receiversFrom<SnapshotStoreError> for io::ErrorimplementationTests
Type of change
Related Issues
This change is