Skip to content

fix: use full join keys for hash shuffle to avoid skew #19198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhang2014 merged 2 commits into from
Jan 7, 2026
Merged

fix: use full join keys for hash shuffle to avoid skew #19198

zhang2014 merged 2 commits into from
Jan 7, 2026
+52 −49

Conversation

@dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Jan 6, 2026 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix: use full join keys for hash shuffle to avoid skew

use full equi-join key set to avoid single-column hash shuffle

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 6, 2026
@dqhl76 dqhl76 marked this pull request as ready for review January 6, 2026 06:57
@zhang2014 zhang2014 added the ci-cloud Build docker image for cloud test label Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Docker Image for PR

  • tag: pr-19198-76258c0-1767694045

note: this image tag is only available for internal use.

@zhang2014 zhang2014 merged commit 2f8f463 into databendlabs:main Jan 7, 2026
99 checks passed
dqhl76 added a commit to dqhl76/databend that referenced this pull request Jan 8, 2026
@dqhl76
fix: use full join keys for hash shuffle to avoid skew (databendlabs#…
c0afdfd 
…19198)

* Use full join keys for hash shuffle

* fix: test
@dqhl76 dqhl76 mentioned this pull request Jan 12, 2026
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees

No one assigned

Labels

ci-cloud Build docker image for cloud test pr-bugfix this PR patches a bug in codebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dqhl76 @zhang2014