refactor(query): reduce string allocations in hot paths #19201
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Reduce unnecessary string allocations in frequently-executed code paths by replacing inefficient string concatenation patterns with direct
write!()calls.Changes
Query result formatting (
physical_plans/format/common.rs): Replace+= &format!()withwrite!()to avoid intermediate String allocations in pruning statistics generationParser errors (
parser/error.rs): Usewrite!()instead of+= &format!()patternOptimizer trace (
optimizer/pipeline/trace/trace.rs): Replacepush_str(&format!())withwrite!()/writeln!()throughout the trace report generationBefore:
After:
These paths are executed per-query, making allocation reduction meaningful at scale.
Continues the work from #19163.
Tests
Type of change
This change is