fix: roll back h2 upgrade and ineffective reset workarounds #19264
+2,291
−3,208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabendlabs#19253)" This reverts commit 84f7338.
…abs#19243)" This reverts commit 5451e1a.
This reverts commit f885633.
…ort (databendlabs#19200)" This reverts commit 05caa2e.
bohutang
changed the title
bohutang
changed the title
sundy-li
approved these changes
Jan 15, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 991715f847
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Update st_geomfromgeohash polygon coordinate order in golden file to match reverted behavior. The revert of PR databendlabs#19200 changed the polygon ring starting point back to the original order, but the unit test golden file was not updated. This commit fixes the geometry.txt golden file to match the actual output after the revert. Related to CI failure in test_unit job.
- geometry.txt: fix Row 1 (u4pruydqqvj0) polygon coordinate order - geometry.txt: fix internal Output hex representation - cast.txt: update date parsing error message format to match new jiff library error format The error message format changed from: 'failed to parse year in date: failed to parse four digit integer as year' to: 'failed to parse year in date "X": failed to parse "Y" as year (a four digit integer)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Revert the h2 upgrade introduced in #19200 and revert subsequent attempted mitigations (#19241/#19243/#19253) that didn’t resolve internal tests hitting
too_many_internal_resets, restoring behavior to the pre-upgrade state.Reverts included:
chore(query): bump ast to 0.2.4 and optimize gRPC configsfix(test): force HTTP/1.1 for sqllogictests clientfix(ci): increase pool_max_idle_per_hostfeat(iceberg): bump iceberg-rust to v0.8.0 and add write support(includes the h2 upgrade chain)Tests
too_many_internal_resetsType of change
This change is