Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix musl support #4520

Merged
merged 2 commits into from
Mar 21, 2022
Merged

build: Fix musl support #4520

merged 2 commits into from
Mar 21, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Mar 21, 2022

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix #830

pprof-rs doesn't support building on musl for a long time, I have a workaround for it tikv/pprof-rs#110

Now, databend works on musl:

PKG_CONFIG_ALLOW_CROSS=1 cargo build --target x86_64-unknown-linux-musl

Please give this PR a test to make sure it also work on macOS too ❤️

Changelog

  • Build/Testing/CI

Test Plan

Unit Tests

Stateless Tests

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/7YxAMk265925cr1arAMhDahWts1A
✅ Preview: Canceled

[Deployment for 3bd4b0e canceled]

@mergify
Copy link
Contributor

mergify bot commented Mar 21, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label Mar 21, 2022
@ZhiHanZ
Copy link
Collaborator

ZhiHanZ commented Mar 21, 2022

could we add statically linked binaries into release workflow, as the issue mentioned before #4513

@Xuanwo Xuanwo requested a review from PsiACE March 21, 2022 04:24
@BohuTANG BohuTANG requested a review from ZhiHanZ March 21, 2022 04:30
Copy link
Collaborator

@ZhiHanZ ZhiHanZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should incorporate musl distro into release workflow, plus could it work with aarch64-unknown-linux-musl target?

Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify mergify bot merged commit cfc9719 into databendlabs:main Mar 21, 2022
@Xuanwo Xuanwo deleted the fix-musl branch March 21, 2022 07:50
@BohuTANG
Copy link
Member

The musl memory allocation maybe the performance issue, please see:
rust-lang/rust#70108 (comment)

But it needs to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-review pr-build this PR changes build/testing/ci steps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[profiling] ubuntu-latest for x86_64-unknown-linux-musl: cannot find function pthread_getname_np in crate libc
5 participants