-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix musl support #4520
build: Fix musl support #4520
Conversation
Signed-off-by: Xuanwo <[email protected]>
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/databend/databend/7YxAMk265925cr1arAMhDahWts1A [Deployment for 3bd4b0e canceled] |
Thanks for the contribution! Please review the labels and make any necessary changes. |
could we add statically linked binaries into release workflow, as the issue mentioned before #4513 |
Signed-off-by: Xuanwo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should incorporate musl distro into release workflow, plus could it work with aarch64-unknown-linux-musl target?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
The musl memory allocation maybe the performance issue, please see: But it needs to be tested. |
Signed-off-by: Xuanwo [email protected]
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
Fix #830
pprof-rs doesn't support building on musl for a long time, I have a workaround for it tikv/pprof-rs#110
Now, databend works on
musl
:Please give this PR a test to make sure it also work on
macOS
too ❤️Changelog
Test Plan
Unit Tests
Stateless Tests