Skip to content

fix: materialized_view with persist_docs not updating existing comments #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: materialized_view with persist_docs not updating existing comments #1276

wants to merge 2 commits into from

Conversation

@vergenzt
Copy link

@vergenzt vergenzt commented Nov 27, 2025

Resolves #1275

Description

See thorough writeup in #1275 (comment).

I still need to run/add integration tests - this PR would likely be a good candidate for having some.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benc-db benc-db Awaiting requested review from benc-db benc-db will be requested when the pull request is marked ready for review benc-db is a code owner

@ericj-db ericj-db Awaiting requested review from ericj-db ericj-db will be requested when the pull request is marked ready for review ericj-db is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vergenzt