Skip to content

Add instanceUrl validation #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangxinlei wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add instanceUrl validation #28

Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
40a675b
Modify oauthConig.
wangxinlei Nov 25, 2020
118060a
Remove instanceUrl from requiredAttrlist, move custom domain field to
wangxinlei Dec 3, 2020
3bb3191
Remove instanceUrl from requiredAttrlist, move custom domain field to
wangxinlei Dec 3, 2020
3d50213
Merge branch 'master' of https://github.com/wangxinlei/tableau-connec…
wangxinlei Dec 3, 2020
1e698ec
Update connection-fields.xml
wangxinlei Dec 3, 2020
830035e
Update connection-fields.xml
wangxinlei Dec 3, 2020
0ce31a4
Update connection-fields.xml
wangxinlei Dec 3, 2020
4c304b5
Update connection-builder.js
wangxinlei Dec 3, 2020
7cc9ae0
Merge branch 'master' of https://github.com/databricks/tableau-connec…
wangxinlei Dec 3, 2020
c75d35e
Change instanceurl from Advanced to Authentication
wangxinlei Dec 3, 2020
7691fdf
Merge branch 'master' of https://github.com/wangxinlei/tableau-connec…
wangxinlei Dec 3, 2020
3092a3f
Add instanceUrl validation.
wangxinlei Dec 4, 2020
5e2cc89
Merge branch 'master' of https://github.com/databricks/tableau-connec…
wangxinlei Dec 4, 2020
e66fde7
Update oauth-config.xml
wangxinlei Apr 15, 2021
4029df2
Merge remote-tracking branch 'upstream/master' into master
wangxinlei Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tableau-databricks/oauth-config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

<authUri>/oauth2/v2.0/authorize</authUri>
<tokenUri>/oauth2/v2.0/token</tokenUri>
<instanceUrlValidationRegex>^https:\/\/([a-zA-Z0-9-.]+\.)?((microsoftonline\.(com|us|cn|de))|chinacloudapi\.cn)\/(.*)</instanceUrlValidationRegex>
Copy link
Contributor Author

@wangxinlei wangxinlei Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for additional security enhancement to guarantee we will not go to a malicious url even someone open the twb and manually change the instanceUrl and send to a victim.


<scopes>openid</scopes>
<scopes>email</scopes>
Expand All @@ -19,6 +20,10 @@
<scopes>2ff814a6-3304-4ab8-85cb-cd0e6f879c1d/user_impersonation</scopes>

<capabilities>
<entry>
<key>OAUTH_CAP_REQUIRES_PROMPT_SELECT_ACCOUNT</key>
Copy link
Contributor Author

@wangxinlei wangxinlei Apr 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for always prompt user to select an account instead of directly log them in if they're already logged in.

<value>true</value>
</entry>
<entry>
<key>OAUTH_CAP_SUPPORTS_CUSTOM_DOMAIN</key>
<value>true</value>
Expand Down