Profiler CLI #1623
Open
Profiler CLI #1623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundarshankar89
changed the base branch from
main
to
feature/synapse_data_collector
|
✅ 19/19 passed, 1m20s total Running from acceptance #1134 |
gueniai
reviewed
Jun 3, 2025
asnare
reviewed
Jun 4, 2025
…ntry_point # Conflicts: # src/databricks/labs/lakebridge/assessments/profiler.py # src/databricks/labs/lakebridge/cli.py
|
✅ 32/32 passed, 2 flaky, 2m27s total Flaky tests:
Running from acceptance #2255 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 25, 2025
## Changes ### What does this PR do? Sometimes a profiler run will contain incomplete or corrupt outputs, leading to delays with the customer. This PR adds a classes for defining table validation checks and receiving validation outcomes as a list or Spark DataFrame outputs. These checks will be used to validate that a profiler run was successful and an accurate TCO estimate will be made prior to sending the information to the Databricks team. ### Relevant implementation details ### Caveats/things to watch out for when reviewing: ### Linked issues N/A ### Functionality - [ ] added relevant user documentation - [ ] added new CLI command - [ ] modified existing command: `databricks labs lakebridge ...` - [X] To be hooked into the profiler CLI when #1623 is merged. ### Tests - [X] manually tested - [X] added unit tests - [ ] added integration tests
sundarshankar89
temporarily deployed
to
tool
GitHub Actions
Inactive
sundarshankar89
temporarily deployed
to
tool
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This introduces the intial version of CLI
Relevant implementation details
Caveats/things to watch out for when reviewing:
Linked issues
Resolves #..
Functionality
databricks labs remorph ...Tests