Simplify Assessment CLI Prompts for Azure Synapse #1940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| azure_api_access = { | ||
| "development_endpoint": self.prompts.question("Enter development endpoint"), | ||
| "development_endpoint": f"https://{synapse_workspace['name']}.dev.azuresynapse.net", | ||
| "azure_client_id": self.prompts.question("Enter Azure client ID"), |
There was a problem hiding this comment.
I m also thinking of removing client id and rather have them az login? thoughts?
There was a problem hiding this comment.
+1 to this idea. For users who choose to generate a token via az login, it makes this prompt ineffective
| "Enter the ODBC driver installed locally", default="ODBC Driver 18 for SQL Server" | ||
| ), | ||
| } | ||
| synapse_workspace["dedicated_sql_endpoint"] = f"{synapse_workspace['name']}.sql.azuresynapse.net" |
|
✅ 23/23 passed, 1 flaky, 1m40s total Flaky tests:
Running from acceptance #1994 |
7 tasks
|
Covered in #1981 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 6, 2025
…ssessment (#1981) <!-- REMOVE IRRELEVANT COMMENTS BEFORE CREATING A PULL REQUEST --> ## Changes <!-- Summary of your changes that are easy to understand. Add screenshots when necessary, they're helpful to illustrate the before and after state --> ### What does this PR do? - Introduces a new feature to establish a base configurator for Profiler Assessment within the project. ### Relevant implementation details - Adds foundational logic for configurable Profiler Assessments. - Updates or adds new CLI commands to support configuration. - Modifies existing command: `databricks labs lakebridge configure-database-profiler` - Merges changes from PR #1940, co-authored by @goodwillpunning. ### Caveats/things to watch out for when reviewing: ### Linked issues <!-- DOC: Link issue with a keyword: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved. See https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> Resolves #.. ### Functionality - [ ] added relevant user documentation - [x] added new CLI command - [ ] modified existing command: `databricks labs lakebridge ...` - [ ] ... +add your own ### Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [x] manually tested - [ ] added unit tests - [ ] added integration tests --------- Co-authored-by: Guenia Izquierdo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Simplify the prompts for the Azure Synapse Assessment CLI.
What does this PR do?
Relevant implementation details
The serverless SQL endpoint, dedicated SQL endpoint, and development endpoint follow a predicatable and repeatable pattern based on the name of an Azure Synapse workspace name. The formats are as follows:
Since these values can be automatically derived from the workspace name, the user only needs to be prompted to enter the name of the workspace they would like to profile. This PR removes the 3 redundant prompts.
Caveats/things to watch out for when reviewing:
Linked issues
N/A
Functionality
databricks labs lakebridge ...Tests