Skip to content

Conversation

m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Sep 2, 2025

Changes

What does this PR do?

  • Add more telemetry notably transpiler version when running transpile command.
  • change morpheus installation destination
  • uninstall old installations of morpheus

Caveats/things to watch out for when reviewing:

This change requires that the transpilers use consistent names when installed and when they get executed. there was a discrepancy for Morpehus because it gets installed under the dir databricks-morph-plugin and not morpheus which is the name in config.yml

if this is the case the user has to reinstall morpheus

Linked issues

Resolves #..

Functionality

  • added relevant user documentation
  • added new CLI command
  • modified existing command:
  • databricks labs lakebridge transpile
  • databricks labs lakebridge install-transpile

Tests

  • manually tested
  • added unit tests
  • added integration tests

Copy link

github-actions bot commented Sep 2, 2025

✅ 23/23 passed, 2 flaky, 1m30s total

Flaky tests:

  • 🤪 test_transpiles_informatica_with_sparksql (9.752s)
  • 🤪 test_transpile_sql_file (13.153s)

Running from acceptance #2155

@m-abulazm m-abulazm added enhancement New feature or request feat/cli actions that are visible to the user do-not-merge morpheus Issues related to Morpheus converter labels Sep 4, 2025
@m-abulazm m-abulazm self-assigned this Sep 4, 2025
@m-abulazm m-abulazm marked this pull request as ready for review September 4, 2025 16:05
@m-abulazm m-abulazm requested a review from a team as a code owner September 4, 2025 16:05
print(json.dumps(result))


def _add_user_agent_extras(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend to rename this to _add_user_agent_extras_transpile (or something like that), since we also need to set a few extras on the analyze command

@m-abulazm m-abulazm marked this pull request as draft September 10, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge enhancement New feature or request feat/cli actions that are visible to the user morpheus Issues related to Morpheus converter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants