-
Notifications
You must be signed in to change notification settings - Fork 74
Add transpiler version to telemetry #1982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
m-abulazm
wants to merge
6
commits into
main
Choose a base branch
from
feat/telemetry/mvp-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ 23/23 passed, 2 flaky, 1m30s total Flaky tests:
Running from acceptance #2155 |
94ec5d8
to
726f8aa
Compare
726f8aa
to
7bb9de7
Compare
7bb9de7
to
2301c15
Compare
2301c15
to
0bccf69
Compare
gueniai
reviewed
Sep 5, 2025
print(json.dumps(result)) | ||
|
||
|
||
def _add_user_agent_extras( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend to rename this to _add_user_agent_extras_transpile
(or something like that), since we also need to set a few extras on the analyze
command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge
enhancement
New feature or request
feat/cli
actions that are visible to the user
morpheus
Issues related to Morpheus converter
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
transpile
command.Caveats/things to watch out for when reviewing:
This change requires that the transpilers use consistent names when installed and when they get executed. there was a discrepancy for
Morpehus
because it gets installed under the dirdatabricks-morph-plugin
and notmorpheus
which is the name inconfig.yml
if this is the case the user has to reinstall morpheus
Linked issues
Resolves #..
Functionality
databricks labs lakebridge transpile
databricks labs lakebridge install-transpile
Tests