Skip to content

Ensure we output transpiled code #2014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 16, 2025
Merged

Ensure we output transpiled code #2014

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e67beba
change output file to transpiled code
gueniai Sep 11, 2025
ed3614e
added tests and remove redundant conditional
gueniai Sep 23, 2025
accc13b
cleanup
gueniai Sep 23, 2025
d692cc4
Merge branch 'main' into output_transpiled_code
gueniai Sep 23, 2025
fca31df
fix fmt
gueniai Sep 23, 2025
db41a81
more fmt fixes
gueniai Sep 23, 2025
ea5723e
remove redundant file
gueniai Sep 23, 2025
4a4f907
Merge branch 'main' into output_transpiled_code
sundarshankar89 Oct 16, 2025
a40467e
refactored tests
sundarshankar89 Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/databricks/labs/lakebridge/transpiler/execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def _process_non_mime_result(context: TranspilingContext, error_list: list[Trans
output_path = cast(Path, context.output_path)

if any(err.kind == ErrorKind.PARSING for err in error_list):
output_code = context.source_code or ""
output_code = context.transpiled_code or ""
Copy link
Contributor

@vil1 vil1 Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove the whole if

elif output_path.suffix == ".sql":
output_code = _validate_transpiled_sql(context, output_code, error_list)
with output_path.open("w") as w:
Expand Down
Loading