Skip to content

Conversation

m-abulazm
Copy link
Contributor

Changes

What does this PR do?

  • fix broken docs link when running reconcile from cli
  • fix deployed reconcile jobs to use correct wheel when running from cli

Relevant implementation details

  • the name of the python task is parsed from the wheel path to be future proof. the parsing asserts that lakebridge is part of the name

Linked issues

Resolves #1972 and #1971

Functionality

  • modified existing command:
  • databricks labs lakebridge reconcile
  • databricks labs lakebridge configure-reconcile

Tests

  • manually tested
  • added unit tests
  • added integration tests

@m-abulazm m-abulazm self-assigned this Sep 23, 2025
@m-abulazm m-abulazm requested a review from a team as a code owner September 23, 2025 10:22
@m-abulazm m-abulazm added bug Something isn't working feat/recon making sure that remorphed query produces the same results as original tech debt design flaws and other cascading effects labels Sep 23, 2025
Copy link

github-actions bot commented Sep 23, 2025

✅ 29/29 passed, 1 flaky, 1m12s total

Flaky tests:

  • 🤪 test_transpile_sql_file (8.352s)

Running from acceptance #2373

@m-abulazm m-abulazm requested review from bishwajit-db and removed request for asnare September 24, 2025 07:53
Copy link
Contributor

@asnare asnare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I have some small questions that I've noted inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feat/recon making sure that remorphed query produces the same results as original tech debt design flaws and other cascading effects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Default jobs created for reconcile fails as could not find databricks_labs_remorph package
2 participants