-
Notifications
You must be signed in to change notification settings - Fork 80
prompt for recon secrets #2157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactor/creds-manager
Are you sure you want to change the base?
prompt for recon secrets #2157
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/creds-manager #2157 +/- ##
==========================================================
- Coverage 65.26% 65.04% -0.23%
==========================================================
Files 100 100
Lines 8533 8484 -49
Branches 887 884 -3
==========================================================
- Hits 5569 5518 -51
- Misses 2773 2774 +1
- Partials 191 192 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 11 flaky, 3m44s total Flaky tests:
Running from acceptance #3129 |
# Conflicts: # src/databricks/labs/lakebridge/install.py # tests/unit/test_install.py
gueniai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
What does this PR do?
Add prompts during
configure-reconcilefor the data sources' credentials. this allows users to use local, env or databricks secrets.this is more flexible and secure than the current approach that requires users to create a secret specifically for reconcile and now users can reuse their existing secrets.
Also allows reconcile to support new vault types e.g. azure, google secrets as we implement more supported backends in the future
Linked issues
Progresses #1008, #2123, #2159
Functionality
databricks labs lakebridge configure-reconcileTests