-
Notifications
You must be signed in to change notification settings - Fork 80
Add support to convert ETL workloads to SDP in switch #2173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2173 +/- ##
=======================================
Coverage 65.24% 65.24%
=======================================
Files 100 100
Lines 8506 8509 +3
Branches 876 877 +1
=======================================
+ Hits 5550 5552 +2
- Misses 2769 2770 +1
Partials 187 187 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 10 flaky, 3m56s total Flaky tests:
Running from acceptance #3076 |
bcda98b to
cdf053d
Compare
|
|
||
| switch_options = {} | ||
| if output_sdp: | ||
| switch_options["output_sdp"] = "true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same changes need to go into SwitchDeployment _generate_switch_job_parameters method as well, which deploys the switch job during
databricks labs lakebridge install-transpile --include-llm-transpile true which deploys artifacts for switch to execute.
Changes
Add
output_sdpboolean flag to lakebridge to support convert to Spark Declarative Pipeline in switch. After the change being released, we can run command like this:Relevant implementation details
Allowlist the boolean flag and passed it to options to switch.
Caveats/things to watch out for when reviewing:
Linked issues
Resolves #..
Functionality
databricks labs lakebridge ...Tests