-
Notifications
You must be signed in to change notification settings - Fork 80
consolidate tests #2179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consolidate tests #2179
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
- Coverage 65.14% 63.56% -1.58%
==========================================
Files 100 100
Lines 8503 8503
Branches 885 885
==========================================
- Hits 5539 5405 -134
- Misses 2774 2931 +157
+ Partials 190 167 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 10 flaky, 4m9s total Flaky tests:
Running from acceptance #3137 |
sundarshankar89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gueniai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@gueniai with this PR we need to update our required checks since we changed the name here before we merge |
Keep integration and unit test scopes only
prerequisite to #2145