Skip to content

Conversation

@m-abulazm
Copy link
Contributor

@m-abulazm m-abulazm commented Dec 4, 2025

Keep integration and unit test scopes only

prerequisite to #2145

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.56%. Comparing base (0349ea8) to head (4e37df0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2179      +/-   ##
==========================================
- Coverage   65.14%   63.56%   -1.58%     
==========================================
  Files         100      100              
  Lines        8503     8503              
  Branches      885      885              
==========================================
- Hits         5539     5405     -134     
- Misses       2774     2931     +157     
+ Partials      190      167      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

✅ 51/51 passed, 10 flaky, 4m9s total

Flaky tests:

  • 🤪 test_validate_non_empty_tables (7ms)
  • 🤪 test_validate_invalid_source_tech (182ms)
  • 🤪 test_validate_successful_schema_check (181ms)
  • 🤪 test_validate_table_not_found (1ms)
  • 🤪 test_validate_invalid_schema_check (0s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (21.603s)
  • 🤪 test_transpiles_informatica_to_sparksql (23.072s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (25.277s)
  • 🤪 test_transpile_teradata_sql (25.937s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (5.456s)

Running from acceptance #3137

@m-abulazm m-abulazm marked this pull request as ready for review December 4, 2025 16:39
@m-abulazm m-abulazm requested a review from a team as a code owner December 4, 2025 16:39
@m-abulazm m-abulazm self-assigned this Dec 4, 2025
Copy link
Collaborator

@sundarshankar89 sundarshankar89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gueniai gueniai added the internal technical pr's not end user facing label Dec 9, 2025
Copy link
Collaborator

@gueniai gueniai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sundarshankar89
Copy link
Collaborator

@gueniai with this PR we need to update our required checks since we changed the name here before we merge

@sundarshankar89 sundarshankar89 added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit f5b447f Dec 10, 2025
7 checks passed
@sundarshankar89 sundarshankar89 deleted the consolidate-tests branch December 10, 2025 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal technical pr's not end user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants