Skip to content

Conversation

@asnare
Copy link
Contributor

@asnare asnare commented Dec 9, 2025

Changes

This PR tweaks the way we launch python-based LSP launchers, mainly to help with developer workflows in the latest IntelliJ release. The issue here is that when running individual tests via the IDE, as of the latest release the (hatch-created) virtual environment is not activated: this causes many tests to run the stub LSP server against the system python, or fail because the system only provides python3 (and not python).

Relevant implementation details

The key change here is that if the LSP server is python-based but there's no dedicated .venv for it, the LSP server is now always launched with the current python interpreter.

As a related minor improvement, we also raise an error earlier if the executable we're about to launch can't be found.

Tests

  • manually tested
  • existing unit tests
  • existing integration tests

…n activated.

This is a common situation when running from IDEs.
If nothing else, this includes our intent.
@asnare asnare self-assigned this Dec 9, 2025
@asnare asnare requested a review from a team as a code owner December 9, 2025 11:30
@asnare asnare added the internal technical pr's not end user facing label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.52%. Comparing base (5a297d2) to head (25b3d59).

Files with missing lines Patch % Lines
...ricks/labs/lakebridge/transpiler/lsp/lsp_engine.py 37.50% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2184      +/-   ##
==========================================
- Coverage   63.56%   63.52%   -0.04%     
==========================================
  Files         100      100              
  Lines        8503     8508       +5     
  Branches      885      887       +2     
==========================================
  Hits         5405     5405              
- Misses       2931     2934       +3     
- Partials      167      169       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

✅ 51/51 passed, 10 flaky, 3m56s total

Flaky tests:

  • 🤪 test_validate_successful_schema_check (203ms)
  • 🤪 test_validate_invalid_schema_check (1ms)
  • 🤪 test_validate_non_empty_tables (11ms)
  • 🤪 test_validate_invalid_source_tech (315ms)
  • 🤪 test_validate_table_not_found (1ms)
  • 🤪 test_transpiles_informatica_to_sparksql (21.116s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (22.696s)
  • 🤪 test_transpile_teradata_sql (24.66s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (5.985s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (12.85s)

Running from acceptance #3150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal technical pr's not end user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants