-
Notifications
You must be signed in to change notification settings - Fork 80
[TECH DEBT]: Refactor @lsp_feature mechanism for marking LSP client callbacks
#2185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asnare
wants to merge
7
commits into
main
Choose a base branch
from
cleanup-lsp-feature-decorators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mechanism is now contained within a specific base-class.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
==========================================
+ Coverage 63.56% 63.65% +0.09%
==========================================
Files 100 100
Lines 8503 8536 +33
Branches 885 887 +2
==========================================
+ Hits 5405 5434 +29
- Misses 2931 2934 +3
- Partials 167 168 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ 51/51 passed, 9 flaky, 4m11s total Flaky tests:
Running from acceptance #3149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this PR do?
This PR refactors the
@lsp_featuredecorator mechanism that was implemented internally to mark LSP client callbacks. We're going to have a lot more callbacks, and the existing mechanism had some drawbacks:The existing mechanism has been replaced with a self-contained mechanism encapsulated within a base class. (For convenience the decorator remains a module function so it can be easily invoked.) The new mechanism also supports asynchronous callbacks.
Relevant implementation details
The PyGLS library doesn't allow for easy subclassing of
LanguageClientwith methods on the subclass as callbacks: callbacks can only be set up after the client has been instantiated, which poses a problem for subclassing like this. The decorator mechanism here works as such:Tests