You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_lookup_via_postgres_api calls GET /api/2.0/postgres/projects once without following next_page_token. That endpoint paginates at 10 projects/page, so in workspaces with more than 10 Postgres projects, an project past page 1 is invisible to this lookup — causing the misleading error "No Lakebase Autoscaling endpoint matched... legacy Provisioned instances are not supported", even with a valid, correctly-permissioned project.
Confirmed in production (2026-09-04): the project was on page 2 of 19. Fix: loop over next_page_token until exhausted.
N/A — single-file fix, no formal plan doc for this one.
Type of change
feat — new feature
fix — bug fix
docs — documentation only
refactor — no behaviour change
test — tests only
perf — perf improvement
ci / build / chore — tooling
Author checklist
Conventional Commit PR title (<type>(<scope>): <subject>).
changelogs/<today>.log updated with title + context + numbered changes + files + test result.
Tests added or modified for every behaviour change.
uv run pytest tests/<scope>/ green locally.
pre-commit run --all-files clean (or skipped hooks documented).
If src/agents/** or any MLflow-traced LLM path changed:
SPEC.md present in .planning/<slug>/.
tests/eval/datasets/<agent>/dataset.jsonl has ≥20 examples (new) or ≥10 (change).
MLflow eval run URI in PR body below.
Judge score ≥ baseline + delta, or explicit waiver here.
If src/mcp-server/** changed: uv run pytest tests/mcp/ -m mcp green.
No gsd-* references re-introduced.
MLflow eval run
Test plan
uv run pytest tests/ -m "not e2e and not property and not eval" --cov-fail-under=90
Per-package coverage thresholds (scripts/check_coverage.py) green for touched packages.
If new MCP tool: uv run pytest tests/mcp/integration/test_tool_schemas.py includes it.
Reviewer hint
See docs/PR_REVIEW_CHECKLIST.md. Numbered items map 1:1 to comments — #3: missing OntoBricksError subclass for new condition is more useful than "fix error handling".
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
Thanks for the diagnosis and the patch — the next_page_token loop in _lookup_via_postgres_api is the right idea, and the production note (project on page 2 of 19) is exactly the failure mode.
This PR is superseded. The same bug is already fixed on the maintained branches (not on master, which is why GitHub still shows #160 open):
Please close this PR rather than merging it onto master. The landed fix is a bit broader than this diff:
Shared helper — LakebaseProjectService.list_projects follows every next_page_token and sets page_size=100 (API max). This PR keeps the default ~10/page, so a 19-project workspace still needs two round-trips; fine, but we wanted one shared loop.
Same one-shot GET in two other callers — Settings (graph_engine_lakebase_projects_result) and provisioning (LakebaseProvisioner._resolve_project_path) had the identical truncation. Auth-only pagination would still leave the dropdown and provisioner broken in large workspaces.
Misleading error — the “legacy Provisioned instances are not supported” copy is unchanged here. After a full walk with no host match, the landed code reports that no listed Autoscaling endpoint matched PGHOST.
Tests / changelog — no regression for a page-2 host, and the author checklist changelog/tests boxes are still unchecked.
Happy to take a follow-up if anything in the landed helper doesn’t cover your workspace. Closing #160 against the develop / 0.9.0 commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't workingstatus: SolvedGreat news the issue is now solved or implemented !
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_lookup_via_postgres_apicallsGET /api/2.0/postgres/projectsonce without followingnext_page_token. That endpoint paginates at 10 projects/page, so in workspaces with more than 10 Postgres projects, an project past page 1 is invisible to this lookup — causing the misleading error "No Lakebase Autoscaling endpoint matched... legacy Provisioned instances are not supported", even with a valid, correctly-permissioned project.Confirmed in production (2026-09-04): the project was on page 2 of 19. Fix: loop over
next_page_tokenuntil exhausted.Linked Issue / milestone
Closes #160
Plan
N/A — single-file fix, no formal plan doc for this one.
Type of change
Author checklist
<type>(<scope>): <subject>).changelogs/<today>.logupdated with title + context + numbered changes + files + test result.uv run pytest tests/<scope>/green locally.pre-commit run --all-filesclean (or skipped hooks documented).src/agents/**or any MLflow-traced LLM path changed:SPEC.mdpresent in.planning/<slug>/.tests/eval/datasets/<agent>/dataset.jsonlhas ≥20 examples (new) or ≥10 (change).src/mcp-server/**changed:uv run pytest tests/mcp/ -m mcpgreen.gsd-*references re-introduced.MLflow eval run
Test plan
uv run pytest tests/ -m "not e2e and not property and not eval" --cov-fail-under=90scripts/check_coverage.py) green for touched packages.uv run pytest tests/mcp/integration/test_tool_schemas.pyincludes it.Reviewer hint
See
docs/PR_REVIEW_CHECKLIST.md. Numbered items map 1:1 to comments —#3: missing OntoBricksError subclass for new conditionis more useful than "fix error handling".