Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to support Telco requirements #50

Merged
merged 29 commits into from
Sep 25, 2023
Merged

Changes to support Telco requirements #50

merged 29 commits into from
Sep 25, 2023

Conversation

abhis2112
Copy link
Collaborator

@abhis2112 abhis2112 commented Jul 20, 2023 •
edited
Loading

Changes:

  1. Show interface name as labels for node to leaf edges.
  2. Show multiple links for multiple ifaces.
  3. Remove VM_Host from graph(Temp change for baremetal case)
  4. See the interface details on the pod-to-node graph.
  5. Color code edge for primary iface link and links of secondary ifaces.
  6. Read the nodefabricnetworkattachment, get connection info and provide the new link for worker node to leaf node (different coloring).
  7. Remove arrows from "Pod & Nodes" view.
  8. Fix bug where the pod to node edges were duplicated on graph regeneration.
  9. Read the pod based interface information from nodefabricnetworkattachment CR.
  10. Changes for modified structure of nodefabricnetworkattachment CR.
  11. Move role and rolebinding to access nodefabricnetworkattachments from neo4j template to vkaci template.
  12. Modify the queries as per the new pod information from nodefabricnetworkattachment CR.
  13. Add PF, VF for SRIOV ifaces.
  14. Fix bug where duplicate nodes were shown.
  15. Fixed query incase node_leaf_all_iface_conn is empty to show worker node and its pods
  16. Removed the VM host between the node(s) and leaf(s) for baremetal case.
  17. Fixed the bug of links between node(s) and leaf(s) getting same label for baremetal case
  18. Fixed the issue of graph not updating on regenerating the graph after deleting the CR.
  19. Removed labels from the queries
  20. Wrapped the CR fetch in try except block
  21. Removed dragview from neovis
  22. Removed unnecessary commas while showing interfaces name
  23. Added optional match for primary link query
  24. Fix node/pod topology in absence of VM_HOST node
  25. Add auto-detect functionality for ESX/Baremetal
  26. Fix labels for the node
  27. Added more UTs related to SRIOV and macvlan
  28. Check nfad type based on primarycni field
  29. Adding check in helm template to add role/rolebinding if CNO is enabled

@abhis2112
Changes to support Telco requirements
261a873 
Changes:
1. Show interface name as labels for node to leaf edges.
2. Show multiple links for multiple ifaces.
3. Remove VM_Host from graph(Temp change for baremetal case)
4. See the interface details on the pod-to-node graph.
5. Color code edge for primary iface link and links of secondary ifaces.
6. Read the nodefabricnetworkattachment, get connection info and provide the new link for worker node to leaf node (different coloring).
7. Remove arrows from "Pod & Nodes" view.
8. Fix bug where the pod to node edges were duplicated on graph
   regeneration.
9. Read the pod based interface information from nodefabricnetworkattachment CR.
10. Changes for modified structure of nodefabricnetworkattachment CR.
11. Move role and rolebinding to access nodefabricnetworkattachments from
   neo4j template to vkaci template.
12. Modify the queries as per the new pod information from
   nodefabricnetworkattachment CR.
13. Add PF, VF for SRIOV ifaces.
14. Fix bug where duplicate nodes were shown.
15.  Fixed query incase node_leaf_all_iface_conn is empty to show worker
    node and its pods
16.  Removed the VM host between the node(s) and leaf(s) for baremetal
    case.
17.  Fixed the bug of links between node(s) and leaf(s) getting same
    label for baremetal case
18.  Fixed the issue of graph not updating on regenerating the
    graph after deleting the CR.
19. Removed labels from the queries
20. Wrapped the CR fetch in try except block
21. Removed dragview from neovis
22. Removed unnecessary commas while showing interfaces name
23. Added optional match for primary link query
24. Fix node/pod topology in absence of VM_HOST node
@abhis2112
Copy link
Collaborator Author

Work in Progress. Do not merge. Currently for tracking changes

burhan20 and others added 18 commits July 27, 2023 10:45
@burhan20
Telco requirements:
19c7a48 
Changes:
1. Removed arrows from pod, leaf and node topology
2. Added filter for bgp peers in table view
3. Added VM in between node and leaf for SRIOV/MacVlan
4. Modified the logic and wrote additional queries to support
    baremetal, VM host, and a combination of both
5. Fixed crash in Node and Pod topology for non baremetal case
6. Fixed crash in Node Topology in upstream code when node is not
    connected to leaf or VM host
@burhan20
Optimized and reordered queries, modified info on hover over node, ad…
94c463f 
…ded info to VM
@burhan20
Displayed primary iface on hovering over node in non baremetal case a…
f1f7f67 
…nd preceeded iface name with leaf name
@abhis2112
Merge pull request #5 from noironetworks/burhan-telco
45e8d7a 
1. Support Hybrid Topology
2. Adding comments to queries
3. Correct Information when hovering node and VM_HOST
@burhan20
Showing sec links only when pod is also present and removed extra ifa…
78e1546 
…ce from primary link
@abhis2112
Merge pull request #8 from noironetworks/vkaci-comments
b327e51 
Showing sec links only when pod is also present and removed extra ifa…
@burhan20
fixed ut failure
b640dca
@abhis2112
Merge pull request #9 from noironetworks/ut-failure
1c2b50c 
fixed ut failure
@burhan20
Added more testcases for sriov and macvlan
93fb1a1
@burhan20
Made changes to queries so that when pod is present then only node to…
733175c 
… leaf/vm links are displayed in primary, sriov and macvlan cases
@burhan20
Fixed Pod and Node topology view so that node-leaf/vm links are visib…
781c4b2 
…le only when pod is also present
@abhis2112
Merge pull request #11 from noironetworks/sriov-macvlan-pod
028e6a6 
Made changes to queries so that when pod is present then only node to…
@burhan20
optimized testcases
d1dee47
@burhan20
fixed query crash if there is no pod with primary link running on a node
b4a2a30
@abhis2112
Merge pull request #10 from noironetworks/testcases
06bd268 
Added more testcases for sriov and macvlan
@abhis2112
Merge pull request #12 from noironetworks/node-with-only-sec-pods
33ab194 
fixed query crash if there is no pod with primary link running on a node
@burhan20
added ut for sriov macvlan pod in diff ns
8d8465d
@abhis2112
Merge pull request #13 from noironetworks/ut_ns
ed697b5 
added ut for sriov macvlan pod in diff ns
camrossi
camrossi requested changes Sep 5, 2023
View reviewed changes
app/graph.py Outdated Show resolved Hide resolved
camrossi
camrossi requested changes Sep 7, 2023
View reviewed changes
helm/templates/nfna_clusterrole.yaml Show resolved Hide resolved
helm/templates/clusterrole.yaml Outdated Show resolved Hide resolved
@abhis2112
Merge pull request #17 from noironetworks/cno
d0fb484 
reverted cno check for clusterrole
@camrossi camrossi requested a review from samiib September 7, 2023 05:22
samiib
samiib requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the read me can be updated based on the latest changes would be really appreciated.

app/graph.py Outdated Show resolved Hide resolved
app/graph.py Outdated Show resolved Hide resolved
app/template/assets/cui-2.0.0/js/vkaci.js Show resolved Hide resolved
app/graph.py Outdated Show resolved Hide resolved
app/graph.py Show resolved Hide resolved
app/template/index.html Show resolved Hide resolved
@abhis2112
Copy link
Collaborator Author

If the read me can be updated based on the latest changes would be really appreciated.

Sure, Will look into it

@samiib samiib merged commit 071d91d into datacenter:main Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samiib samiib samiib approved these changes

@camrossi camrossi camrossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhis2112 @camrossi @samiib @burhan20