Handling the Removal of the 'ip' Key in the 'fvCEp' Object for ACI 5.1 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is currently an issue open on github here
Show endpoints sample does retrieve key error in acitoolkit.py · Issue #376 · datacenter/acitoolkit
There was a PR that was not merged and closed closed that talks about changes made to Cisco ACI that caused this issue
Handling the Removal of the 'ip' Key in the 'fvCEp' Object for ACI 5.1 by timway · Pull Request #374 · datacenter/acitoolkit
tldr:
IP key has been removed from the endpoints payload.
Addresses the Dec 15, 2020 remark in
Cisco Application Policy Infrastructure Controller Release Notes, Release 5.1(1)
In ACI 5.1 the fvCEp object no longer contains a key for IP
"Because a fvCEp object can contain multiple fvIp objects it may be
ideal to be more selective on which IP is grabbed or a way to handle
an endpoint having multiple IPs"
This PR aims to address this issue by checking for ip address on endpoint, and if not there, keep ip field blank. For those looking for ips associated to endpoints and their children, there is a attr on endpoint labled secondary_ip which is a list of ips