Ejscreen semi-automatic#1184
Open
Rohit231998 wants to merge 26 commits into
Open
Conversation
krishnaswamypradeep
left a comment
krishnaswamypradeep
left a comment
Contributor
There was a problem hiding this comment.
Please fix the comments provided.
krishnaswamypradeep
left a comment
krishnaswamypradeep
left a comment
Contributor
There was a problem hiding this comment.
Please add the config file in PR as well
krishnaswamypradeep
approved these changes
Jan 24, 2025
krishnaswamypradeep
left a comment
krishnaswamypradeep
left a comment
Contributor
There was a problem hiding this comment.
Thanks Rohit. Looks good
ajaits
reviewed
Jun 20, 2025
ajaits
reviewed
Jun 20, 2025
ajaits
reviewed
Jun 20, 2025
ajaits
reviewed
Jun 20, 2025
ajaits
reviewed
Jun 20, 2025
Contributor
|
@gemini-code-assist review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the EJScreen import script to be configuration-driven, which is a great improvement for maintainability. The introduction of config.json centralizes parameters and makes adding new data years much easier. My review focuses on several critical issues in the new implementation, including a security vulnerability from disabling SSL verification, bugs in error handling and MCF file generation that would cause the script to fail or produce incorrect output. I've also included suggestions to improve code quality by removing global variables and to fix minor issues in the documentation and test files.
ajaits
reviewed
Aug 27, 2025
ajaits
reviewed
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.