Skip to content

Revert to python logging fr log_util.py#1599

Merged
ajaits merged 14 commits into
datacommonsorg:masterfrom
ajaits:statvar-log
Sep 3, 2025
Merged

Revert to python logging fr log_util.py#1599
ajaits merged 14 commits into
datacommonsorg:masterfrom
ajaits:statvar-log

Conversation

@ajaits

@ajaits ajaits commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

absl.logging doesn't have functions like getLogger().
Revert to python logging instead of absl.logging

ajaits and others added 14 commits August 30, 2025 02:38
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @ajaits, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on standardizing the logging mechanism within util/log_util.py by switching from absl.logging to the native Python logging module. This change aims to ensure consistency and potentially resolve any integration issues or preferences related to the logging framework used in this utility file.

Highlights

  • Logging Module Reversion: The util/log_util.py file has been updated to revert its logging implementation from absl.logging back to the standard Python logging module. This change removes the absl.logging import and replaces it with a direct import of the logging module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly reverts util/log_util.py to use Python's standard logging module instead of absl.logging. This change improves the module's portability by reducing external dependencies. The implementation is sound, and I find no issues with it. This is a good improvement.

@hareesh-ms hareesh-ms self-requested a review September 3, 2025 08:49
@ajaits ajaits enabled auto-merge (squash) September 3, 2025 08:54
@ajaits ajaits merged commit ecdac77 into datacommonsorg:master Sep 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants