Move version update to cloud workflow

[vish-cs]

• Split import executor to move version update logic to a separate cloud run function which is invoked by the import automation workflow. The executor updates a file staging_version.txt in GCS with the current information which is then used by the cloud function to update latest version info.
• Externalize all GCP parameters to cloud build variables to enable dev/prod deployment
• Add dataflow ingestion metrics to IngestionHistory table
• Move import version history to a new spanner table (ImportVersionHistory)
• update_import_version.sh uses cloud function instead of a batch job
• Make config_override from global to per-import in manifest.json
• Update import_hepper cloud function to invoke ingestion workflow (non auto-refresh imports)
• Split import latest version to add graph paths (list) param
• Refactor spanner ingestion workflow with smaller improvements

[gemini-code-assist]

Summary of Changes

Hello @vish-cs, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the import automation system by centralizing the management of Spanner import job status updates within the Cloud Workflow, rather than the Python ImportExecutor. This change streamlines the ImportExecutor's initialization by having it internally construct its dependencies from a configuration object. The updated workflow now explicitly handles both failure reporting and a final status update, ensuring more robust and consistent tracking of import processes.

Highlights

• Spanner Update Relocation: The logic responsible for updating import job statuses in Spanner has been removed from the Python ImportExecutor class, indicating a shift in where this operation is managed.
• Executor Initialization Refactor: The ImportExecutor class's constructor has been simplified. It now takes a single config object and internally initializes its dependencies (file uploader, GitHub API client, email notifier) based on this configuration.
• Cloud Workflow Status Handling: The Cloud Workflow has been updated to directly manage import status updates. This includes a specific step for marking imports as failed and a general status update step at the end of the workflow execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the Spanner status update logic by moving it from the Python executor to a Google Cloud Workflow. This is a positive architectural change that improves separation of concerns. The simplification of the ImportExecutor constructor is also noted. However, I have identified a critical issue in the updated workflow definition that will cause it to fail on the success path due to missing parameters in a call to a helper function. I have also included a medium-severity comment regarding a design change in the ImportExecutor constructor that negatively impacts testability.