Skip to content

fixed sat act data#1797

Merged
HarishC727 merged 2 commits into
datacommonsorg:masterfrom
HarishC727:sat_act_fix
Dec 24, 2025
Merged

fixed sat act data#1797
HarishC727 merged 2 commits into
datacommonsorg:masterfrom
HarishC727:sat_act_fix

Conversation

@HarishC727

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @HarishC727, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the accuracy and consistency of SAT/ACT participation data imports for urban schools in the US. It involves updating configuration metadata, refining data mapping logic, and standardizing template references to ensure proper data processing and integration with the Data Commons API.

Highlights

  • API Root Configuration: Added the Data Commons API root URL to the metadata configuration for SAT/ACT participation data.
  • Data Mapping Refinements: Updated the property-value mapping file by removing irrelevant entries and adjusting measurement denominators for percentage calculations to improve data accuracy.
  • Template Standardization: Standardized entity references in the output template file for consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SAT/ACT participation data import. The changes include adding a dc_api_root configuration, updating the property-value mappings to correct percentage calculations and ignore certain metrics, and generalizing the test TMCF. The changes look mostly good and seem to fix issues with the data processing. I've left a couple of comments on the pvmap.csv file regarding a potentially incorrect geographical mapping and a possible typo in one of the keys. Please take a look.

@HarishC727 HarishC727 merged commit fce847a into datacommonsorg:master Dec 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants