Implemented Golden EurostatData_Education_Attainment, EurostatData_Education_Enrollment, EurostatData_Demographic_Balance_Crude_Rates#2086
Open
niveditasing wants to merge 5 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a golden summary report and configures validation rules for the Eurostat regional education attainment statistics. The feedback highlights an incorrect relative path for the golden data file in the validation configuration, which needs to be corrected to prevent validation failures.
niveditasing
changed the title
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These imports have recurring deletion failures less than 0.1%. To tackle these small deletions, the threshold has increased, but we also added a new golden check. These validation checks will verify that the data contains all sets in a golden set, these are defined within the validation_config.json file, which is situated in the same directory as manifest.json. The threshold has been raised to 0.1, a value determined by historical and current deletion percentages, with a small buffer to account for these minor deletions.
PR checklist: https://docs.google.com/spreadsheets/d/1BzweR9Sj58j0H2_BweGTmfE4Z1lrjPZL8u1FS0kzCeg/edit?pli=1&gid=0#gid=0