Skip to content

Redo statvar examples#717

Open
kmoscoe wants to merge 4 commits into
datacommonsorg:masterfrom
kmoscoe:data
Open

Redo statvar examples#717
kmoscoe wants to merge 4 commits into
datacommonsorg:masterfrom
kmoscoe:data

Conversation

@kmoscoe

@kmoscoe kmoscoe commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Rewrite stat var section to use a correct measuredProperty and statType, and add other fields, like measurementDenominator. Update CSV examples.

@kmoscoe kmoscoe requested a review from carojahn July 2, 2026 17:46

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the custom data documentation (custom_dc/custom_data.md) to revise the example statistical variables representing UN WHO cigarette smoking prevalence. The review feedback correctly identifies that Female and Male are not valid Class types in Data Commons and therefore cannot be used as populationType. The reviewer suggests reverting populationType to Person and using gender as a constraint property instead. Additionally, the feedback addresses a property name mismatch, a spelling typo ("prevelance" vs "prevalence"), and provides corresponding updates to the explanatory text.

Comment thread custom_dc/custom_data.md Outdated
Comment thread custom_dc/custom_data.md Outdated
Comment thread custom_dc/custom_data.md Outdated
Comment thread custom_dc/custom_data.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant