Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added script to clear autopush redis cache #4444

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dwnoble
Copy link
Contributor

@dwnoble dwnoble commented Jul 4, 2024

No description provided.

@dwnoble dwnoble requested a review from shifucun July 4, 2024 11:44
@shifucun
Copy link
Contributor

shifucun commented Jul 4, 2024

I don't think we should add any cache to autopush, otherwise it will not be "autopush"

@dwnoble dwnoble requested review from juliawu and krishnaswamypradeep and removed request for krishnaswamypradeep July 10, 2024 19:00
Copy link
Contributor

@juliawu juliawu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for adding a script, but agree with @shifucun that we should discuss whether we should have caching on autopush. Does the cache clear cache each time autopush is redeployed or does that need to happen manually?

@dwnoble
Copy link
Contributor Author

dwnoble commented Jul 10, 2024

Sorry missed bo's comment from last week. Looks like caching was added to autopush here: #4029 but it's only for NL models, not for views.

@dwnoble dwnoble marked this pull request as draft November 19, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants