fix: persist session renames through state.db sync - #1
Merged
Conversation
Renames previously updated the local sessions.json cache first and swallowed state.db errors, so the UI looked successful until the next syncSessionCache restored the old Hermes title. Write the durable DB row first (honoring unique titles and the 100-char cap), only then mirror into the cache, and toast/rollback when the write fails. Co-authored-by: Cursor <cursoragent@cursor.com>
Pull title policy into src/shared/session-title and the optimistic rename UX into confirmSessionRename so the sidebar and Sessions modal stop duplicating toast/rollback/refocus logic. Keeps both screens under the 1k-line ceiling and prevents UI/DB whitespace drift on rename. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.dbbefore updating the localsessions.jsoncache, sosyncSessionCachecannot resurrect the old titleUpstream PR: fathah#865
Test plan
npm test -- tests/session-cache-sync.test.ts src/shared/session-title.test.tsnpm run typecheckMade with Cursor