fix: make published GMS and frontend ports configurable with quickstart #15494
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
devops
datahub-cyborg
bot
added
the
needs-review
daha
force-pushed
the
make-external-gms-and-frontend-ports-configurable-with-quickstart
branch
from
d39413b to
1ee4d39
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the docker-compose file which I get when running did not allow to change the published port for GMS and frontend like many of the other docker images support, like https://docs.datahub.com/docs/troubleshooting/quickstart#common-problems suggest with
DATAHUB_MAPPED_GMS_PORT. This change make the published ports for GMS and frontend configurable with environment variables when runningdatahub docker quickstart.