Skip to content

Fix ambiguous wording for security groups/subnets #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ambiguous wording for security groups/subnets #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions parameter-sets/networking-settings/parameter-set.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
"params": [
{
"name": "subnets",
"label": "VPC subnets",
"label": "VPC subnets IDs",
"type": "STRINGS",
"description": "Put at least 2 subnets. Check https://eksctl.io/usage/vpc-configuration/#use-existing-vpc-other-custom-configuration for constraints.",
"description": "Put at least 2 subnets IDs (not names). Check https://eksctl.io/usage/vpc-configuration/#use-existing-vpc-other-custom-configuration for constraints.",
"mandatory" : false
},
{
Expand All @@ -26,30 +26,30 @@
},
{
"name": "privateSubnets",
"label": "VPC private subnets",
"label": "VPC private subnets IDs",
"visibilityCondition": "model.privateNetworking == true",
"type": "STRINGS",
"description": "Put at least 2 subnets. Check https://eksctl.io/usage/vpc-configuration/#use-existing-vpc-other-custom-configuration for constraints.",
"description": "Put at least 2 subnets IDs (not names). Check https://eksctl.io/usage/vpc-configuration/#use-existing-vpc-other-custom-configuration for constraints.",
"mandatory" : false
},
{
"name": "securityGroups",
"label": "Security groups",
"label": "Security groups IDs",
"type": "STRINGS",
"description": "Additional security groups for the nodes. Needed to give access to the node running DSS",
"description": "Additional security groups IDs (not names) for the nodes. Needed to give access to the node running DSS",
"mandatory" : false
},
{
"name": "controlPlaneSG",
"label": "Control plane SG",
"label": "Control plane SG ID",
"type": "STRING",
"description": "Optional: Control Plane will be put in this SG. Must allow inbound from DSS if you don't use Shared SG"
"description": "Optional: Control Plane will be put in this SG. Must allow inbound access from DSS if you don't use the Shared SG"
},
{
"name": "sharedSG",
"label": "Shared SG",
"label": "Shared SG ID",
"type": "STRING",
"description": "Optional: Control Plane, Nodes and VPC endpoints will be put in this SG. Should be allow inbound from DSS"
"description": "Optional: Control Plane, Nodes and VPC endpoints will be put in this SG. Should allow inbound access from DSS"
}
]
}