Feature/sc 245546 add multiple paths write #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding batch endpoint
Feature/batch write af
alexbourret
changed the base branch from
feature/sc-241566-add-elementname-column-to-attribute-search
to
master
JaneBellaiche
requested changes
Sep 26, 2025
|
Tested with different sizes of streak and batch buffer
|
Co-authored-by: Jane Bellaiche <[email protected]>
| } | ||
| # mark in self.responses that status of this write depends on result of streak X | ||
| if self.current_webid is None: | ||
| logger.info("webid now is {}".format(webid)) |
There was a problem hiding this comment.
format a lil bit
also, do we want to show every webid?
Suggested change
| logger.info("webid now is {}".format(webid)) | |
| logger.info("webid : {}".format(webid)) |
| } | ||
| ) | ||
| self.row_number += 1 | ||
| logger.info("Pushed in buffer, now {}".format(len(self.streak_buffer))) |
There was a problem hiding this comment.
Could improve this log, it's not very clear what is after "now"
There was a problem hiding this comment.
LGTM 👍 Some logs are, I think, some rests of the helpers used to debug. Let's make sure the logs are clear and not too much redondant before merging the PR. Maybe, every X items in the buffer should be logged. Or just at the beginning and the end of the buffer. I let you find the best depending on what's needed for the client in term of log details and clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/dataiku/story/245546