-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add injection schema #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
reviewed
Aug 23, 2023
kabilar
previously requested changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kushalbakshi! Please see my comments above, and please update the docs (with a dj.Diagram and API docs table) and docstrings.
kabilar
reviewed
Aug 24, 2023
kabilar
reviewed
Aug 24, 2023
kabilar
reviewed
Aug 24, 2023
kabilar
reviewed
Aug 24, 2023
Co-authored-by: Kabilar Gunalan <[email protected]>
kabilar
reviewed
Sep 8, 2023
kabilar
reviewed
Sep 22, 2023
kabilar
reviewed
Sep 22, 2023
Co-authored-by: Kabilar Gunalan <[email protected]>
Co-authored-by: Kabilar Gunalan <[email protected]>
ttngu207
reviewed
Oct 3, 2023
ttngu207
previously approved these changes
Oct 3, 2023
ttngu207
previously approved these changes
Oct 3, 2023
ttngu207
dismissed
kabilar’s stale review
October 3, 2023 15:04
all requested changes have been addressed
ttngu207
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds injection schema - tables related to viral injections (AAV, RSV, etc.) in the brain. In the current design, the injection schema contains tables with foreign keys to tables in the surgery schema, requiring the surgery module to be activated first.
Before merging, the following will need to be addressed and resolved:
Implantation
which refers to an implantation surgery. Since a viral injection can be an independent surgery from an implant, a table redesign is likely necessary. A suggested redesign of the surgery module could take the form of: adding a Lookup tableSurgeryType
with options forImplant
,ViralInjection
,Implant + ViralInjection
, and a downstreamSurgery
table containing theSurgeryType
table as one of its attributes.version.py