Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add injection schema #43

Merged
merged 13 commits into from
Oct 3, 2023
Merged

Add injection schema #43

merged 13 commits into from
Oct 3, 2023

Conversation

kushalbakshi
Copy link
Collaborator

@kushalbakshi kushalbakshi commented Aug 15, 2023

This PR adds injection schema - tables related to viral injections (AAV, RSV, etc.) in the brain. In the current design, the injection schema contains tables with foreign keys to tables in the surgery schema, requiring the surgery module to be activated first.

Before merging, the following will need to be addressed and resolved:

  • Currently, the surgery module contains a table for Implantation which refers to an implantation surgery. Since a viral injection can be an independent surgery from an implant, a table redesign is likely necessary. A suggested redesign of the surgery module could take the form of: adding a Lookup table SurgeryType with options for Implant, ViralInjection, Implant + ViralInjection, and a downstream Surgery table containing the SurgeryType table as one of its attributes.
  • Add docstrings to new tables.
  • Add / update documentation for the new tables and any table redesign.
  • Apply Black formatting
  • Update version.py
  • Update CHANGELOG

Copy link
Collaborator

@kabilar kabilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kushalbakshi! Please see my comments above, and please update the docs (with a dj.Diagram and API docs table) and docstrings.

requirements.txt Outdated Show resolved Hide resolved
element_animal/surgery.py Outdated Show resolved Hide resolved
element_animal/surgery.py Outdated Show resolved Hide resolved
element_animal/injection.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
kushalbakshi and others added 2 commits September 22, 2023 11:01
Co-authored-by: Kabilar Gunalan <[email protected]>
@kabilar kabilar removed their request for review September 28, 2023 17:16
ttngu207
ttngu207 previously approved these changes Oct 3, 2023
element_animal/injection.py Outdated Show resolved Hide resolved
ttngu207
ttngu207 previously approved these changes Oct 3, 2023
@ttngu207 ttngu207 dismissed kabilar’s stale review October 3, 2023 15:04

all requested changes have been addressed

@ttngu207 ttngu207 merged commit a609e49 into datajoint:main Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants