Convert to nwb #44
Merged
Convert to nwb #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBroz1
reviewed
Dec 22, 2021
* docstrings * json dump insertion into location * ignore channel_conversion if all are 1 * black formatting
dimitri-yatsenko
requested changes
Jan 12, 2022
Co-authored-by: Dimitri Yatsenko <[email protected]>
Co-authored-by: Dimitri Yatsenko <[email protected]>
Co-authored-by: Dimitri Yatsenko <[email protected]>
* black * upgrade to latest version of conversion-tools * upgrade to latest spikeinterface api *
# Conflicts: # element_array_ephys/export/nwb.py
|
Could you display the contents of |
it looks like this worked. The test is running through correctly now |
kabilar
reviewed
Mar 22, 2022
kabilar
reviewed
Mar 22, 2022
kabilar
reviewed
Mar 22, 2022
kabilar
reviewed
Mar 22, 2022
kabilar
reviewed
Mar 22, 2022
kabilar
reviewed
Mar 22, 2022
kabilar
requested changes
Mar 22, 2022
There was a problem hiding this comment.
Thanks @bendichter! Appreciate your work on this. It will be great for DataJoint Elements users to have a simple way to export to NWB.
I have reviewed the pull request and left my comments above. Let's aim to merge this pull request and workflow-array-ephys#50 by the end of the week.
Co-authored-by: Kabilar Gunalan <[email protected]>
Co-authored-by: Kabilar Gunalan <[email protected]>
kabilar
reviewed
Apr 18, 2022
kabilar
reviewed
Apr 18, 2022
Co-authored-by: Kabilar Gunalan <[email protected]>
Co-authored-by: Kabilar Gunalan <[email protected]>
Co-authored-by: Kabilar Gunalan <[email protected]>
|
Hi @bendichter, please remove the |
|
@kabilar done |
dimitri-yatsenko
requested changes
Apr 27, 2022
element_array_ephys/export/nwb.py
Outdated
| @@ -46,7 +43,7 @@ def __init__(self, lfp_electrodes_query, chunk_length: int = 10000): | |||
| self.electrodes = self.lfp_electrodes_query.fetch("electrode") | |||
|
|
|||
| first_record = ( | |||
| self.lfp_electrodes_query & dict(electrode=self.electrodes[0]) | |||
| self.lfp_electrodes_query & dict(electrode=self.electrodes[0]) | |||
| ).fetch(as_dict=True)[0] | |||
There was a problem hiding this comment.
Suggested change
| ).fetch(as_dict=True)[0] | |
| ).fetch(as_dict=True, limit=1)[0] |
Co-authored-by: Dimitri Yatsenko <[email protected]>
Co-authored-by: Dimitri Yatsenko <[email protected]>
kabilar
approved these changes
May 9, 2022
kabilar
pushed a commit
to kabilar/element-array-ephys
that referenced
this pull request
Jun 26, 2023
Change dependency installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on datajoint/element-session#7
needs tests