-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to parallel workflow integration tests #40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @CBroz1! Looks good in overall. Left some small comments.
Co-authored-by: Tolga Dincer <[email protected]>
Include updated CICD
Hi @tdincer - Merged your PR and fetched from upstream. Do you have time to finish review here today, so we can deploy to codebook tomorrow? The only remaining item on this is the To summarize:
This would be backwards incompatible in the unlikely situation in which someone (a) had multiple roots, with their main project dir not in the first, and (b) expected results to be stored in the first without defining @kabilar - Let me know if you have any thoughts on this |
Thank you @CBroz1! I'm merging this now but I'll run some tests to check these changes next week. |
See also Workflow PR
In this PR:
KeyboardInterrupt
#26insert_new_params
#27config["video_sets"]
to be dict, we save as list #36dlc_config_file
#38analyze_videos
fails when passed defaultNone
videotype #42Reserved for future PRs:
train
schema #25