Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update model.py,tutorial notebook,changelog, and version #92

Merged
merged 11 commits into from
Oct 26, 2023
Merged

update model.py,tutorial notebook,changelog, and version #92

merged 11 commits into from
Oct 26, 2023

Conversation

MilagrosMarin
Copy link
Collaborator

@MilagrosMarin MilagrosMarin commented Oct 18, 2023 •
edited
Loading

  • Update minor changes in markdown of the tutorial notebook
  • Fix dlc_config to not be dicts, only varchar in model.py
  • Fix shuffle arg description in model.py
  • Update project_path in insert_new_model function
  • Remove updating config file at the end of insert_new_model function
  • Update Changelog file
  • Update version file

@MilagrosMarin MilagrosMarin marked this pull request as ready for review October 19, 2023 20:26
@MilagrosMarin MilagrosMarin changed the title update changelog and version update model.py,tutorial notebook,changelog, and version Oct 25, 2023
ttngu207
ttngu207 previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ttngu207 ttngu207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MilagrosMarin thanks for the PR. Looks good. I have one very minor comment, otherwise good to merge

@ttngu207 ttngu207 merged commit c887ab8 into datajoint:main Oct 26, 2023
1 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttngu207 ttngu207 ttngu207 approved these changes

@sidhulyalkar sidhulyalkar Awaiting requested review from sidhulyalkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MilagrosMarin @ttngu207