Update get_nd2_list function #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
sidhulyalkar
commented
Aug 16, 2023
sidhulyalkar
commented
- Adds functionality to pull the specified tiff_list from the ops parameters, and to restriction the construction of the .nd2 file list to the specified files.
…only be pulled from the list
ttngu207
reviewed
Aug 16, 2023
suite2p/io/utils.py
Outdated
| fsall.append(os.path.join(froot[0], tif)) | ||
| ops["first_tiffs"] = np.zeros((len(fsall),), dtype="bool") | ||
| ops["first_tiffs"][0] = True | ||
| print("** Found %d nd2 files - converting to binary **" % (len(fsall))) |
There was a problem hiding this comment.
This is duplicated again below, you can just move this out of the if/else block.
ttngu207
reviewed
Aug 16, 2023
Co-authored-by: Thinh Nguyen <[email protected]>
sidhulyalkar
changed the title
ttngu207
reviewed
Aug 16, 2023
Co-authored-by: Thinh Nguyen <[email protected]>
ttngu207
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.