-
Notifications
You must be signed in to change notification settings - Fork 316
New Optical Flow OP & Allow to save the computed optical flows #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @HYLcool, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the video motion score filters by allowing users to persist the computed optical flow data. Previously, optical flow was an internal calculation used solely for determining motion scores. With this change, users can now opt to save this detailed motion information directly into the dataset's metadata, providing greater flexibility for downstream analysis or further processing. This feature is implemented across both the standard "VideoMotionScoreFilter" and the "VideoMotionScoreRaftFilter". Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a useful feature to optionally save computed optical flows in two video motion score filters. The implementation is mostly correct, but I've identified a critical issue that could lead to a crash when processing videos with few frames or corrupted data. Additionally, there's a minor typo in a docstring, and the new tests could be more robust. I've provided specific suggestions to address these points.
# Conflicts: # pyproject.toml
+ add remarks to distinguish two motion score filters
# Conflicts: # data_juicer/ops/filter/video_motion_score_filter.py # tests/ops/filter/test_video_motion_score_filter.py
As the title says.