Skip to content

Conversation

@HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Jan 9, 2026

  • update dockerfile to install embodied-related packages
  • use uv in unit test directly
  • update cuda version to 12.6.3 and ubuntu version to 24.04
  • update to python 3.11

* use uv directly
* update cuda version to 12.6.3 and ubuntu version to 24.04
@HYLcool HYLcool self-assigned this Jan 9, 2026
@HYLcool HYLcool added dj:ci/cd issues/PRs about CI/CD of Data-Juicer environment related to third-party dependency, DJ-pypi, DJ-docker, etc. labels Jan 9, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @HYLcool, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive update to the project's Docker environment. The core changes involve modernizing the underlying operating system and CUDA versions, upgrading the Python runtime, and integrating new simulation and robotics-related frameworks. These updates aim to provide a more current and capable development environment, particularly for tasks involving embodied AI or simulation, while also refining existing dependency installations.

Highlights

  • Base Image and Python Upgrade: The Dockerfile has been updated to use a newer base image, upgrading from nvidia/cuda:12.4.1-cudnn-devel-ubuntu22.04 to nvidia/cuda:12.6.3-cudnn-devel-ubuntu24.04. This also includes an upgrade of the default Python version within the container from 3.10 to 3.11.
  • Embodied-Related Packages Integration: Significant additions have been made to install embodied-related packages, specifically isaacsim[all,extscache]==5.1.0 and IsaacLab v2.3.0, along with necessary system dependencies and Vulkan setup for NVIDIA.
  • System Dependencies and Tooling Enhancements: Various system dependencies have been expanded, including the installation of Git LFS, gcc-11/g++-11, and a more comprehensive set of graphics and development libraries. The recognize-anything package source has also been updated to a Git repository.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/perf-bench.yml
    • .github/workflows/unit-test-partial.yml
    • .github/workflows/unit-test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dockerfile to use newer versions of CUDA, Ubuntu, and Python, and adds several new dependencies for 'embodied-related packages' like Isaac Sim and Isaac Lab. The changes are extensive and generally improve the setup.

My review focuses on Dockerfile best practices to optimize image size and ensure build reproducibility. I've suggested:

  • Combining multiple RUN commands into single layers.
  • Cleaning up apt cache after installations to reduce image size.
  • Pinning a git-based dependency to a specific commit to ensure reproducible builds.

These changes should help in creating a more efficient and maintainable Docker image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dj:ci/cd issues/PRs about CI/CD of Data-Juicer environment related to third-party dependency, DJ-pypi, DJ-docker, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants