Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis fine tuning #8

Merged
merged 4 commits into from
Aug 26, 2021
Merged

Redis fine tuning #8

merged 4 commits into from
Aug 26, 2021

Conversation

abhi4578
Copy link
Contributor

@abhi4578 abhi4578 commented Aug 26, 2021 •
edited
Loading

  • use of one connection per redis verticle instance with pipelining using maxwaiting handlers, refer issue,apidocs, pipelining in redis.
  • explicitly make redis client only use master in ingestion pipeline by setting setUseSlave(RedisSlaves.NEVER) in RedisOptions
  • Removal of checking observation datetime logic using json,get for every json.set.
  • attribute-mapping-file read from secrets/attribute-mapping.json :)

kailash
kailash approved these changes Aug 26, 2021
View reviewed changes
Copy link
Contributor

@kailash kailash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaminathanvasanth swaminathanvasanth merged commit d61e6d1 into datakaveri:master Aug 26, 2021
abhi4578 added a commit to abhi4578/iudx-resource-server that referenced this pull request Oct 4, 2021
@abhi4578
Redis tuning
0db018f 
- use of one connection per redis verticle instance with pipelining using maxwaiting handlers
similar to PR datakaveri/latest-ingestion-pipeline#8
@abhi4578 abhi4578 mentioned this pull request Oct 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kailash kailash kailash approved these changes

@swaminathanvasanth swaminathanvasanth Awaiting requested review from swaminathanvasanth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abhi4578 @kailash @swaminathanvasanth