Skip to content

fix: indent issue in the case of no duplicated cols #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vishpillai123 wants to merge 1 commit into from
Closed

fix: indent issue in the case of no duplicated cols #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/edvise/modeling/feature_selection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,10 @@ def drop_collinear_features_iteratively(
grouped = df_features[duplicated_cols].T.groupby(
lambda x: tuple(df_features[x].values), sort=False
)
for _, group in grouped:
dup_cols = list(group.index)
if len(dup_cols) <= 1:
continue
for _, group in grouped:
dup_cols = list(group.index)
if len(dup_cols) <= 1:
continue

# Prefer to keep force-included columns
force_included = [col for col in dup_cols if col in force_include_cols]
Expand Down
Loading