add endpoint to re-send confirm registration email #125
Conversation
|
This doesn't work because of the order of things required. Executing /auth/register/resend returns {"msg": "Missing Authorization Header"} because submitting to /auth/login before a confirmation email link has been opened returns {"error": "Unauthorized","message": "user has been created but is not yet confirmed"}. You should be able to get a valid auth token from /auth/login even when user is_confirmed = 0. Other endpoints can have a guard that prevents response without confirmation, and I have middleware written into the web app to hide most views until confirmation is done, but you have to be able to log in in order to securely request a new email. The email resend itself does work as expected. I just need to be able to trigger it from an unconfirmed user. |
|
I think I'm going to need your help implementing this. How familiar are you with Flask, jwt, etc? |
|
@sophiaharms Let me know if this does what you need! |
| return unauthorized_error("user has been created but is not yet confirmed") | ||
| # TODO: confirm that we want to allow uncomfirmed user logins | ||
| current_app.logger.warning("%s not yet confirmed") | ||
| # return unauthorized_error("user has been created but is not yet confirmed") |
There was a problem hiding this comment.
@sophiaharms belatedly following back up on this -- is this the behavior you need? if so, do you recommend i put safeguards in for other endpoints to require user confirmation??
There was a problem hiding this comment.
@bdewilde colandr-db is failing on both prod and dev builds. I backed up a few commits on develop to confirm this wasn't happening previously.
changes
/register/resendapi endpoint to re-send a registration confirmation email/registerendpointcontext
https://app.asana.com/0/1206730431337718/1209825705665584/f
questions