Skip to content

Conversation

@bdewilde
Copy link
Member

@bdewilde bdewilde commented Apr 12, 2025

changes

  • adds FE_APP_SITE to app config, for use in production, so that confirmation URLs link to the front-end app rather than the back-end api, where we can handle them cleanly
  • builds a different confirmation url for registration confirmation and password reset if this configuration is specified for the app

context

https://app.asana.com/1/6325821815997/project/1206730431337718/task/1209811648565213?focus=true

questions

  • is this what you had in mind?
  • does this work?
  • should i do something similar for other confirmation links?

@bdewilde bdewilde changed the base branch from main to develop April 12, 2025 19:25
@bdewilde bdewilde marked this pull request as ready for review April 12, 2025 19:27
@bdewilde bdewilde requested a review from sophiaharms April 12, 2025 19:27
@sophiaharms
Copy link
Contributor

I'm not able to build from this branch. When I do, http://localhost:5001/docs returns:

{
"error": "Internal Server Error",
"message": "404 Not Found: The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again."
}

@bdewilde
Copy link
Member Author

@sophiaharms sure enough, that localhost url doesn't work when COLANDR_SERVER_NAME is included in .env. however, this config variable is intended for production use, not dev -- does it work in production? or is it having unwanted side-effects in flask's functionality?

i could always follow the example of what I did for v1.0, where a custom server name is included (optionally) as a parameter to the endpoint that generates the confirmation url. what do you think?

@sophiaharms
Copy link
Contributor

@bdewilde I'm not able to get this working in production either. A gunicorn error causes colandr-api to stop. It's spawning 16+ workers, which it does not do on develop. I think I'm just running out of disk space, but I'm running out because something's going wrong here

@bdewilde bdewilde merged commit 6dd9fa2 into develop Oct 26, 2025
4 checks passed
@bdewilde bdewilde deleted the change-register-confirm-url branch October 26, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants