WIP feat: accept binary PDF instead of just path to PDF #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the library expects a filepath to be given to the PdfConverter, the underlying pdfium.PdfDocument constructor supports bytes and other types. Adding 'bytes' as an accepted type for the Document Pydantic model allows binary PDFs to be parsed by the library.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
VikParuchuri
pushed a commit
that referenced
this pull request
Dec 12, 2024
|
Shouldn't this be made by creating a new provider e.g. binary_data provider, cv2_image provider ? |
|
Up, this feature could be very useful ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the library expects a filepath to be given to the PdfConverter, the underlying pdfium.PdfDocument constructor supports bytes and other types. Adding 'bytes' as an accepted type for the Document Pydantic model allows binary PDFs to be parsed by the library.
I've tested this patch manually and things seem to work fine so far, but I'd prefer to add tests for it. However the test suite seems to be heavily built around creating a temporary file, and I'm not sure where to start to test this