Refactor sort_text_lines for Improved Accuracy and Maintainability #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
…enter alignment - Refactored `sort_text_lines` to use a more robust method for sorting text lines in reading order (top-to-bottom, left-to-right). - Introduced helper functions to: - Compute vertical center of lines (`_center_y`) - Group lines into rows based on vertical median tolerance - Sort text within rows horizontally and flatten result - Added `_calculate_row_tolerance` with dynamic tolerance factor based on median line height - Defined `DEFAULT_ROW_TOLERANCE_FACTOR` constant for configurable grouping sensitivity - Improved overall code style, spacing, and docstrings for clarity and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
sort_text_linesfunction inmarker/util.pyto improve robustness, readability, and accuracy when sorting text lines in document layouts.✅ Changes Made:
sort_text_linesto:_calculate_row_tolerance_center_y_group_lines_into_rows_sort_and_flatten_rowsDEFAULT_ROW_TOLERANCE_FACTORbased on median line height for adaptive grouping.🎯 Why This Change?
The previous implementation used a direct y-axis rounding strategy, which could result in incorrect grouping for varying line heights. This refactor makes the function: