Add column for last commit date, allow for subset of columns to be shown, overhaul sorting #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add get_head_commit_date() function to extract commit dates from HEAD - Populate head_dt field in _update_dataset_url_info() - Add configurable columns system with URL parameter support - Add "Last commit date" column with sorting support - Implement dynamic table rendering based on column configuration - Add comprehensive tests for new functionality Fixes #342: Now shows separate "date of the last commit" column and supports configurable columns via URL parameters (e.g. ?columns=url,head_dt) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Complete overhaul of the overview sorting system to eliminate code duplication between _SORT_ATTRS and _AVAILABLE_COLUMNS. The new system uses cleaner URL parameters (sort_by=column&sort=direction) and maintains a single source of truth for column metadata. Key changes: - Remove _SORT_ATTRS dictionary entirely - Add db_field mappings to _AVAILABLE_COLUMNS for database field resolution - Update URL parameter system to use sort_by and sort parameters - Simplify template logic by removing unnecessary conditionals - Update all tests to use new parameter format - Add backward compatibility translation for existing test cases 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made with claude
not tested locally yet