Skip to content

Conversation

@goanpeca
Copy link
Collaborator

Fixes datalayer/vscode-datalayer#40

Tested on VScode

fixes-lexi

@goanpeca goanpeca self-assigned this Oct 17, 2025
@goanpeca goanpeca marked this pull request as ready for review October 17, 2025 20:32
@goanpeca goanpeca requested review from Copilot and echarles October 17, 2025 20:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the select all functionality when inside Jupyter cells by improving the command handler priority and simplifying the logic. The issue was that the default Lexical select-all behavior was interfering with the custom Jupyter cell selection logic.

  • Updated command priority from HIGH to CRITICAL to ensure the custom handler runs before Lexical's internal select-all handler
  • Simplified the node traversal logic by removing excessive debugging console logs
  • Added proper event prevention to stop default browser behavior
Comments suppressed due to low confidence (1)

packages/lexical/src/plugins/JupyterInputOutputPlugin.tsx:1

  • The import for $isJupyterInputHighlightNode is being removed but may still be needed elsewhere in the file. Since this is a diff view and the full file context isn't visible, ensure this import removal doesn't break other functionality that may depend on this helper function.
/*

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @goanpeca

@echarles echarles merged commit 6f27be3 into datalayer:main Oct 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTRL-A in a Jupyter cell should only select the content of the cell

2 participants