Skip to content

Conversation

@goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Oct 17, 2025

Fixes datalayer/vscode-datalayer#34

Enable cell insertion without kernel and improve initial messages

fixes-lexi

@goanpeca goanpeca self-assigned this Oct 17, 2025
@goanpeca goanpeca changed the title Enh/lexical UI Enable cell insertion without kernel and improve initial messages Oct 17, 2025
@goanpeca goanpeca marked this pull request as ready for review October 17, 2025 23:26
Copilot AI review requested due to automatic review settings October 17, 2025 23:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables cell insertion without a kernel and improves initial user messaging for better UX when no runtime is available. The changes focus on making the Jupyter notebook interface more graceful when operating without a connected kernel.

  • Allow Jupyter cell creation and insertion even when no kernel is connected
  • Replace generic error messages with user-friendly warnings about kernel connectivity
  • Improve initial placeholder messages with better styling and clearer instructions

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/react/src/components/output/OutputRenderer.tsx Adds ANSI-to-HTML conversion for colored error output display
packages/react/src/components/output/OutputAdapter.ts Adds setOutputs method for programmatically updating output model
packages/react/src/components/output/Output.tsx Improves output synchronization and Lumino widget updates
packages/react/package.json Adds ansi-to-html dependency for error output formatting
packages/lexical/src/plugins/JupyterInputOutputPlugin.tsx Removes kernel requirement for cell insertion and improves user messaging
packages/lexical/src/plugins/ComponentPickerMenuPlugin.tsx Enables Jupyter cell option regardless of kernel availability
packages/lexical/src/nodes/JupyterOutputNode.tsx Replaces console errors with user-facing warning messages
packages/lexical/src/examples/index.tsx Switches default example to AppSimple
packages/lexical/src/examples/ManualKernelControl.tsx Adds comprehensive example for manual kernel control
packages/lexical/src/examples/AppSimple.tsx Adds kernel toggle functionality for testing

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @goanpeca

@echarles echarles merged commit 59649e9 into datalayer:main Oct 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show UI notice when Lexical document is not connected to a runtime

2 participants