-
-
Notifications
You must be signed in to change notification settings - Fork 61
Enable cell insertion without kernel and improve initial messages #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4b4e4ce to
9d91b92
Compare
9d91b92 to
fa8551e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables cell insertion without a kernel and improves initial user messaging for better UX when no runtime is available. The changes focus on making the Jupyter notebook interface more graceful when operating without a connected kernel.
- Allow Jupyter cell creation and insertion even when no kernel is connected
- Replace generic error messages with user-friendly warnings about kernel connectivity
- Improve initial placeholder messages with better styling and clearer instructions
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
packages/react/src/components/output/OutputRenderer.tsx |
Adds ANSI-to-HTML conversion for colored error output display |
packages/react/src/components/output/OutputAdapter.ts |
Adds setOutputs method for programmatically updating output model |
packages/react/src/components/output/Output.tsx |
Improves output synchronization and Lumino widget updates |
packages/react/package.json |
Adds ansi-to-html dependency for error output formatting |
packages/lexical/src/plugins/JupyterInputOutputPlugin.tsx |
Removes kernel requirement for cell insertion and improves user messaging |
packages/lexical/src/plugins/ComponentPickerMenuPlugin.tsx |
Enables Jupyter cell option regardless of kernel availability |
packages/lexical/src/nodes/JupyterOutputNode.tsx |
Replaces console errors with user-facing warning messages |
packages/lexical/src/examples/index.tsx |
Switches default example to AppSimple |
packages/lexical/src/examples/ManualKernelControl.tsx |
Adds comprehensive example for manual kernel control |
packages/lexical/src/examples/AppSimple.tsx |
Adds kernel toggle functionality for testing |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fa8551e to
c0f29cf
Compare
46c5063 to
7fa326c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thx @goanpeca
Fixes datalayer/vscode-datalayer#34
Enable cell insertion without kernel and improve initial messages