Skip to content

Conversation

@goanpeca
Copy link
Collaborator

@goanpeca goanpeca commented Oct 16, 2025

@goanpeca goanpeca self-assigned this Oct 16, 2025
@netlify
Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for vscode-datalayer ready!

Name Link
🔨 Latest commit 4e2e9e8
🔍 Latest deploy log https://app.netlify.com/projects/vscode-datalayer/deploys/68f6add37af89900086ebb7f
😎 Deploy Preview https://deploy-preview-45--vscode-datalayer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@goanpeca goanpeca force-pushed the fix/undo-redo branch 2 times, most recently from 22c606a to 6916e04 Compare October 16, 2025 17:57
@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2025

📦 Extension Build Ready!

Download the extension (works on all platforms):

📥 Download build artifact

The artifact contains the .vsix extension package.


📖 Installation Instructions

Method 1: VS Code UI

  1. Download the .vsix file above
  2. Open VS Code
  3. Go to Extensions (Ctrl+Shift+X / Cmd+Shift+X)
  4. Click ... menu → "Install from VSIX..."
  5. Select the downloaded file

Method 2: Command Line

code --install-extension datalayer-jupyter-vscode.vsix

Method 3: Drag & Drop

  1. Download the .vsix file
  2. Drag it into the VS Code Extensions sidebar

Note: The .vsix artifact works on Windows, macOS, and Linux.

Built from commit 4e2e9e8 • Version 0.0.4View workflow run

@goanpeca goanpeca requested a review from echarles October 20, 2025 21:49
@goanpeca goanpeca marked this pull request as ready for review October 20, 2025 21:49
Copilot AI review requested due to automatic review settings October 20, 2025 21:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds undo/redo functionality to datalayer notebooks by implementing keyboard shortcuts (Cmd/Ctrl+Z for undo, Cmd/Ctrl+Shift+Z or Ctrl+Y for redo) and refactoring cell insertion operations to use the centralized notebookStore2 state management.

Key changes:

  • Keyboard event handlers for undo/redo operations in NotebookEditor
  • Refactored cell insertion to use notebookStore2 instead of direct NotebookActions calls
  • Webpack configuration updates to ensure single React instance across the application

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
webview/notebook/NotebookToolbar.tsx Refactored code/markdown cell insertion to use notebookStore2.insertBelow() instead of NotebookActions
webview/notebook/NotebookEditor.tsx Added keyboard event listener for undo/redo shortcuts with platform-specific handling
webpack.config.js Added React deduplication via aliases and splitChunks optimization to prevent multiple React instances
patches/@datalayer+jupyter-react+1.1.7.patch Patch file adding undo/redo methods to Notebook2Adapter and Notebook2State, plus React component updates
package.json Added explicit dependency on @datalayer/jupyter-react version 1.1.7

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@echarles echarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thx @goanpeca

@echarles echarles merged commit a30b83a into main Oct 20, 2025
15 checks passed
@goanpeca goanpeca deleted the fix/undo-redo branch October 20, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Datalayer Notebook Editor: command Z doesn't work (on Mac)

3 participants